fix(prism): reuse public Lium template without docker cred - #173
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughLium provisioning now detects missing private-registry credentials, reuses allowlisted public templates when available, and reports an operator-facing error otherwise. The client, tests, environment example, and operator documentation use the new template-resolution behavior. ChangesLium template resolution
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Operator
participant prism-challenge
participant listed_template_id
participant Lium_API
Operator->>prism-challenge: configure template and credential settings
prism-challenge->>Lium_API: list templates
prism-challenge->>listed_template_id: resolve template name, image, and credential
listed_template_id-->>prism-challenge: existing public or private template ID
prism-challenge->>Lium_API: create private template when no fallback applies
Lium_API-->>prism-challenge: template creation result or operator-facing error
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PRISM_POD_DOCKER_CREDENTIAL_IDwas failing every miner provision when creating the private DOfe1197template.prism-recipe-v9/v10(orPRISM_POD_TEMPLATE_ID) instead of 500ing submits; credential remains required only to create a new private template.Test plan
cargo test -p prism-lium-harness -p prism-lium --lib -- public_template_fallback ensure_template_falls_back private_template_creationSummary by CodeRabbit
New Features
prism-recipe-v9andv10templates when private-template creation is unavailable.PRISM_POD_TEMPLATE_IDconfiguration for selecting an existing template.Bug Fixes
Documentation